Add parent context to SpanProcessor.OnStart #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johananl
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
johananl
force-pushed
the
johananl/onstart-parent-context
branch
from
ec9baba
to
8d81fe6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1333 +/- ##
======================================
Coverage 77.3% 77.3%
======================================
Files 123 123
Lines 6067 6067
======================================
Hits 4694 4694
Misses 1120 1120
Partials 253 253
|
johananl
force-pushed
the
johananl/onstart-parent-context
branch
2 times, most recently
from
6832eac
to
e0e5ef3
Compare
MrAlias
approved these changes
Nov 13, 2020
MrAlias
added
area:trace
XSAM
approved these changes
Nov 15, 2020
|
@johananl It looks like maintainer edits are off for this PR. Can you sync with master so we can merge this? |
The spec requires doing so. Right now SpanProcessor implementations aren't doing anything with this argument.
johananl
force-pushed
the
johananl/onstart-parent-context
branch
from
e0e5ef3
to
6f0486b
Compare
|
@MrAlias done! |
Aneurysm9
approved these changes
Nov 16, 2020
Merged
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Add parent context to SpanProcessor.OnStart The spec requires doing so. Right now SpanProcessor implementations aren't doing anything with this argument. * Update changelog * Fix typo in test name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a parent context argument to
SpanProcessor.OnStartfollowing the spec.Fixes #1304.