-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass options to configured TracerProvider #1329
Conversation
|
9599142
to
ebbc27f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ebbc27f
to
cc3659f
Compare
@cbandy sorry, it looks like upstream package reshuffling has caused conflicts here. You should be able to use |
No problem. I can rebase tonight. |
cc3659f
to
18f2d67
Compare
Rebased. |
Codecov Report
@@ Coverage Diff @@
## master #1329 +/- ##
======================================
Coverage 77.5% 77.5%
======================================
Files 125 125
Lines 6090 6090
======================================
Hits 4720 4720
Misses 1119 1119
Partials 251 251
|
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
The global TracerProvider missed some arguments to its configured TracerProvider.
I wasn't sure how to describe the placeholder or the test. Suggestions welcome.
I looked for a similar bug in the global MeterProvider and found none, but the implementation was harder for me to follow there. I am certain, however, the correct behavior isn't covered by current tests. I was able to apply this diff and everything still passed: