Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SpanProcessor Shutdown with context and error #1264

Merged
merged 11 commits into from
Oct 27, 2020
Merged

Update SpanProcessor Shutdown with context and error #1264

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4e58bb8
1232: update SpanProcessor Shutdown with context and error
ilyakaznacheev Oct 18, 2020
985639c
1232: add changelog info
ilyakaznacheev Oct 18, 2020
728c31b
1232: fix CI error, rm commented code
ilyakaznacheev Oct 18, 2020
bcdbb83
1232: fix CI unhandled error
ilyakaznacheev Oct 18, 2020
a821675
1232: Done commit properly
ilyakaznacheev Oct 18, 2020
c7ed83c
Merge branch 'master' into update-span-processor
ilyakaznacheev Oct 23, 2020
c2a006f
Add shutdown error handling
ilyakaznacheev Oct 24, 2020
5dc709d
Merge remote-tracking branch 'fork/update-span-processor' into update…
ilyakaznacheev Oct 24, 2020
b0ef75f
Merge branch 'master' into update-span-processor
MrAlias Oct 27, 2020
5c839b7
Merge branch 'master' into update-span-processor
MrAlias Oct 27, 2020
0053c17
Revert now unneeded context declaration move
MrAlias Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions example/basic/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ func main() {
log.Fatalf("failed to initialize stdout export pipeline: %v", err)
}

ctx := context.Background()

bsp := sdktrace.NewBatchSpanProcessor(exporter)
tp := sdktrace.NewTracerProvider(sdktrace.WithSpanProcessor(bsp))
defer func() { _ = tp.Shutdown(context.Background()) }()
Expand Down Expand Up @@ -78,6 +76,7 @@ func main() {

valuerecorderTwo := otel.Must(meter).NewFloat64ValueRecorder("ex.com.two")

ctx := context.Background()
MrAlias marked this conversation as resolved.
Show resolved Hide resolved
ctx = otel.ContextWithBaggageValues(ctx, fooKey.String("foo1"), barKey.String("bar1"))

valuerecorder := valuerecorderTwo.Bind(commonLabels...)
Expand Down