Update semconv comments #1249
Merged
Update semconv comments #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comments to fix lint issues with the semconv package and add clarifying documentation for attributes.
MrAlias
added
documentation
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
jmacd
approved these changes
Oct 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #1249 +/- ##
======================================
Coverage 76.7% 76.7%
======================================
Files 130 130
Lines 5828 5828
======================================
Hits 4475 4475
Misses 1105 1105
Partials 248 248
|
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
Add comments to fix lint issues with the semconv package and add clarifying documentation for attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comments to fix lint issues with the semconv package and add clarifying documentation for attributes.