-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codes to match specification #1214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:API
Related to an API package
area:trace
Part of OpenTelemetry tracing
release:required-for-ga
labels
Sep 30, 2020
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
September 30, 2020 03:37
MrAlias
added
dependencies
Pull requests that update a dependency file
and removed
dependencies
Pull requests that update a dependency file
labels
Sep 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #1214 +/- ##
========================================
- Coverage 76.7% 76.6% -0.1%
========================================
Files 133 134 +1
Lines 5809 5807 -2
========================================
- Hits 4456 4449 -7
- Misses 1104 1109 +5
Partials 249 249
|
jmacd
approved these changes
Oct 2, 2020
Aneurysm9
approved these changes
Oct 5, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codes
package to match the changes to the specification: Error Flagging with Status Codes opentelemetry-specification#966String
,UnmarshalJSON
, andMarshalJSON
method to thecodes.Code
struct.sdk/export/trace.SpanData
to use theotel/codes
package as there now isn't a 1-to-1 conversion to the gRPC codes and the downstream OTLP is also changing to these codes: Modify Span status according to specification opentelemetry-proto#224Resolves #1213