-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update propagation to conform with OpenTelemetry specification #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:API
Related to an API package
area:propagators
Part of OpenTelemetry context propagation
release:required-for-ga
Skip Changelog
PRs that do not require a CHANGELOG.md entry
labels
Sep 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
======================================
Coverage 76.5% 76.5%
======================================
Files 134 133 -1
Lines 5801 5797 -4
======================================
- Hits 4442 4439 -3
+ Misses 1110 1109 -1
Partials 249 249
|
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
September 29, 2020 23:48
XSAM
approved these changes
Sep 30, 2020
jmacd
approved these changes
Oct 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api/propagation
package in favor of its components being a part of the mainotel
package (part of Move OpenTelemetry API to top level go.opentelemetry.io/otel package #964)Propagators
interface. This collides with the specifications definitions ofPropagator
types and is not needed given the other changes.HTTP*
propagation interfaces with a unifiedTextMapPropagator
andTextMapCarrier
to implement the specifications definition. Instead of breaking outInjector
andExtractor
functionality (which is optional in the specification), this unifies everything into a single interface. The motivation for this is ...TextMapPropagator
. Instead of just specifying you want to use the propagator you need to specify you want to use if for injecting and extracting which is not the common case.TextMapPropagator
that limits this functionality. This is not the common case so the higher barrier to use here seems appropriate.New
function is replaced with aNewCompositeTextMapPropagator
to define the functionality better and keep it in line with the specification.ExportHTTP
andInjectHTTP
function are removed. They were equivalent to method calls on the second parameter.Resolves #1082