Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move api/unit to top level #1185

Merged
merged 3 commits into from
Sep 20, 2020
Merged

Move api/unit to top level #1185

merged 3 commits into from
Sep 20, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 18, 2020

Move the go.opentelemetry.io/otel/api/unit package to go.opentelemetry.io/otel/unit

Part of #1179 and #964

@MrAlias MrAlias added pkg:API Related to an API package release:required-for-ga labels Sep 18, 2020
@MrAlias MrAlias added this to the RC1 milestone Sep 18, 2020
@MrAlias MrAlias self-assigned this Sep 18, 2020
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1185 into master will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1185     +/-   ##
========================================
- Coverage    77.0%   77.0%   -0.1%     
========================================
  Files         135     135             
  Lines        5867    5858      -9     
========================================
- Hits         4521    4512      -9     
  Misses       1104    1104             
  Partials      242     242             
Impacted Files Coverage Δ
api/metric/config.go 80.0% <ø> (ø)
api/metric/descriptor.go 83.3% <ø> (ø)
sdk/trace/batch_span_processor.go 76.1% <0.0%> (-2.4%) ⬇️

@MrAlias MrAlias marked this pull request as ready for review September 18, 2020 19:32
@Aneurysm9 Aneurysm9 merged commit 4b46365 into open-telemetry:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:API Related to an API package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants