Recommend use of initializers for config structs #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates style guide and changes existing configure() implementations to newConfig() as appropriate.
Aneurysm9
requested review from
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1163 +/- ##
======================================
Coverage 77.9% 77.9%
======================================
Files 135 135
Lines 7191 7192 +1
======================================
+ Hits 5602 5604 +2
+ Misses 1346 1344 -2
- Partials 243 244 +1
|
MrAlias
reviewed
Sep 10, 2020
7 tasks
MrAlias
approved these changes
Sep 10, 2020
XSAM
approved these changes
Sep 11, 2020
|
LGTM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates style guide and changes existing configure() implementations to newConfig() as appropriate.