Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ParentOrElse sampler to ParentBased and enhance it according to the spec #1153

Merged
merged 6 commits into from
Sep 10, 2020
Merged

Rename ParentOrElse sampler to ParentBased and enhance it according to the spec #1153

merged 6 commits into from
Sep 10, 2020

Commits on Sep 9, 2020

  1. Rename ParentOrElse to ParentBased and enhance it according to the spec 

    - Renaming of type and sampler function
- Enhancing ParentBased with sampler options
- Set default samplers for each applicable parent-based case
- Adjust ShouldSample(...) func accordingly
    Matej Gera committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    7783130 View commit details
    Browse the repository at this point in the history

  2. Adjust existing tests for ParentBased and add new ones 

    - add tests for ParentBased sampler options and description
- renaming in trace_test.go
    Matej Gera committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    2293972 View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md

    Matej Gera committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    cd0172f View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. PR feedback 

    - More clearer naming of structs; add comments where missing
- Adhere to the configuration style guide
    Matej Gera committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    9e316e9 View commit details
    Browse the repository at this point in the history

  2. PR feedback - punctuation

    Matej Gera committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    61fa4e7 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into parent-based-sampler

    Matej Gera committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    1da1335 View commit details
    Browse the repository at this point in the history