Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing package document and canonical import paths #1125

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Added missing package document and canonical import paths #1125

merged 2 commits into from
Sep 8, 2020

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Sep 7, 2020

Also simplified the first lines of some package docs
to focus on what the package provides instead of
explaining the implementation details.

Also simplified the first lines of some package docs
to focus on what the package provides instead of
explaining the implementation details.
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #1125 into master will increase coverage by 6.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1125     +/-   ##
========================================
+ Coverage    71.2%   77.2%   +6.0%     
========================================
  Files          68     133     +65     
  Lines        3709    7101   +3392     
========================================
+ Hits         2643    5487   +2844     
- Misses        945    1365    +420     
- Partials      121     249    +128     
Impacted Files Coverage Δ
api/trace/tracetest/tracer.go 100.0% <ø> (ø)
label/type_string.go 12.5% <0.0%> (-37.5%) ⬇️
api/metric/kind_string.go 16.6% <0.0%> (-33.4%) ⬇️
api/metric/numberkind_string.go 25.0% <0.0%> (-25.0%) ⬇️
exporters/stdout/config.go 72.0% <0.0%> (ø)
exporters/otlp/options.go 51.7% <0.0%> (ø)
sdk/internal/codes.go 100.0% <0.0%> (ø)
sdk/export/trace/tracetest/test.go 100.0% <0.0%> (ø)
sdk/metric/aggregator/lastvalue/lastvalue.go 83.7% <0.0%> (ø)
sdk/metric/controller/pull/config.go 50.0% <0.0%> (ø)
... and 59 more

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MrAlias MrAlias merged commit 9ad4824 into open-telemetry:master Sep 8, 2020
evantorrie pushed a commit to evantorrie/opentelemetry-go that referenced this pull request Sep 10, 2020
…etry#1125)

Also simplified the first lines of some package docs
to focus on what the package provides instead of
explaining the implementation details.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants