Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move transform_spans.go to internal package #527

Closed
rghetia opened this issue Mar 7, 2020 · 0 comments · Fixed by #593
Closed

move transform_spans.go to internal package #527

rghetia opened this issue Mar 7, 2020 · 0 comments · Fixed by #593
Assignees
@MrAlias

Comments

@rghetia
Copy link
Contributor

rghetia commented Mar 7, 2020

This is to track review comment.
@rghetia rghetia mentioned this issue Mar 7, 2020
Merged
@MrAlias MrAlias self-assigned this Mar 24, 2020
MrAlias referenced this issue in MrAlias/opentelemetry-go Mar 25, 2020
Move span transforms of the OTLP exporter to internal
205ad2a 
Breakup and move functionality of the `transform_spans.go` file into
appropriate files in the `internal/transform` sub-package. This is in
preparation of using some of the overlapping functionality to implement
Resource support in the metric side of the exporter.

Adds more specific unit tests for some of the functionality transferred.
The tests removed used the exporter as a processing engine and the
replacement tests do not do this. The test found in the `oltp_test.go`
seem to comprehensively cover this type of test.

Include Link `Name` in the exporter span link and adds a test to check
for this.

Resolves #527
@MrAlias MrAlias mentioned this issue Mar 25, 2020
Merged
jmacd added a commit that referenced this issue Mar 25, 2020
@MrAlias @rghetia @jmacd
Move span transforms of the OTLP exporter to internal (#593)
c9dcc1b 
* Move span transforms of the OTLP exporter to internal

Breakup and move functionality of the `transform_spans.go` file into
appropriate files in the `internal/transform` sub-package. This is in
preparation of using some of the overlapping functionality to implement
Resource support in the metric side of the exporter.

Adds more specific unit tests for some of the functionality transferred.
The tests removed used the exporter as a processing engine and the
replacement tests do not do this. The test found in the `oltp_test.go`
seem to comprehensively cover this type of test.

Include Link `Name` in the exporter span link and adds a test to check
for this.

Resolves #527

* Apply suggestions from code review

Co-Authored-By: Rahul Patel <rghetia@yahoo.com>

* Fix SpanData doc

* Consolidate span comparison

Co-authored-by: Rahul Patel <rghetia@yahoo.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move span transforms of the OTLP exporter to internal MrAlias/opentelemetry-go
2 participants
@MrAlias @rghetia