Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log/sdk: Document package #5065

Closed
pellared opened this issue Mar 13, 2024 · 1 comment · Fixed by #5609
Closed

log/sdk: Document package #5065

pellared opened this issue Mar 13, 2024 · 1 comment · Fixed by #5609
Assignees
Labels
area:logs Part of OpenTelemetry logs documentation Provides helpful information pkg:SDK Related to an SDK package
Milestone

Comments

@pellared
Copy link
Member

pellared commented Mar 13, 2024

  • Add package level documentation
  • Add testable examples
@pellared pellared added pkg:SDK Related to an SDK package area:logs Part of OpenTelemetry logs documentation Provides helpful information labels Mar 13, 2024
@pellared pellared self-assigned this Jun 25, 2024
@pellared
Copy link
Member Author

I am assigning myself, but anyone can work in parallel with me.

pellared added a commit that referenced this issue Jun 27, 2024
Towards #5065

---------

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared added a commit that referenced this issue Jul 1, 2024
Towards #5065

Follow our own docs. From `Processor.Enabled` docs:

> Before modifying a Record, the implementation must use Record.Clone to
create a copy that shares no state with the original.
pellared added a commit that referenced this issue Jul 1, 2024
pellared added a commit that referenced this issue Jul 6, 2024
Towards #5065

Co-authored-by: Sam Xie <sam@samxie.me>
@MrAlias MrAlias added this to the v1.29.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Part of OpenTelemetry logs documentation Provides helpful information pkg:SDK Related to an SDK package
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants