Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go test ./... and make build fails differently #1140

Closed
rakyll opened this issue Sep 9, 2020 · 2 comments · Fixed by #1154
Closed

go test ./... and make build fails differently #1140

rakyll opened this issue Sep 9, 2020 · 2 comments · Fixed by #1154

Comments

@rakyll
Copy link
Contributor

rakyll commented Sep 9, 2020

When I run go test ./... on the top directory of this repo, it seems to be skipping some packages thus make build and go test fail differently.

It confused me as a new contributor. I opened a few PRs after just running go test and the CI failed. I don't have time to investigate this (and don't know if it's a reasonable ask) but it would be great if go test was working as expected.

@Aneurysm9
Copy link
Member

This seems to relate to this Go issue which seems to acknowledge that the behavior of go test ./... may be unanticipated when multiple modules live in a single repo, but is the intended behavior. Would additional documentation of the necessity of using make test over go test ./... in our CONTRIBUTING.md help address this issue?

@rakyll
Copy link
Contributor Author

rakyll commented Sep 10, 2020

Documenting sounds great, sending a PR.

Aneurysm9 pushed a commit that referenced this issue Sep 10, 2020
evantorrie pushed a commit to evantorrie/opentelemetry-go that referenced this issue Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants