Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename global TraceProvider to TracerProvider #1101

Closed
MrAlias opened this issue Aug 26, 2020 · 1 comment · Fixed by #1102
Closed

Rename global TraceProvider to TracerProvider #1101

MrAlias opened this issue Aug 26, 2020 · 1 comment · Fixed by #1102
Assignees
Labels
area:trace Part of OpenTelemetry tracing pkg:API Related to an API package
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Aug 26, 2020

This naming was in error it should be TracerProvider.

// TraceProvider returns the registered global trace provider.
// If none is registered then an instance of trace.NoopProvider is returned.
//
// Use the trace provider to create a named tracer. E.g.
// tracer := global.TraceProvider().Tracer("example.com/foo")
// or
// tracer := global.Tracer("example.com/foo")
func TraceProvider() trace.Provider {
return internal.TraceProvider()
}

@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 26, 2020

This also needs to include SetTraceProvider -> SetTracerProvider in the same global package.

@MrAlias MrAlias self-assigned this Aug 26, 2020
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this issue Aug 26, 2020
@MrAlias MrAlias added this to the RC1 milestone Aug 27, 2020
MrAlias added a commit that referenced this issue Aug 31, 2020
* Rename global {Set,}TraceProvider

Resolves #1101

* Rename unexported and testing vars
evantorrie pushed a commit to evantorrie/opentelemetry-go that referenced this issue Sep 10, 2020
* Rename global {Set,}TraceProvider

Resolves open-telemetry#1101

* Rename unexported and testing vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing pkg:API Related to an API package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant