Skip to content

Commit

Permalink
Do not always put remote span context into links (#480)
Browse files Browse the repository at this point in the history
When during determining a parent for a new span, we find out that
there is a current span in the context, we are putting a remote span
context into links as an ignored on demand. A problem with this
approach is that the remote span context will end up in links of every
descendant span. Another problem is that jaeger exporter currently
treats all links as span contexts with a "child of" relationship and
that likely confuses the jaeger visualization.
  • Loading branch information
krnowak authored Feb 14, 2020
1 parent cf7a4d9 commit f99337f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions internal/trace/parent/parent.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ func GetSpanContextAndLinks(ctx context.Context, ignoreContext bool) (core.SpanC
return core.EmptySpanContext(), false, links
}
if lsctx.IsValid() {
links := addLinkIfValid(nil, rsctx, "remote")
return lsctx, false, links
return lsctx, false, nil
}
if rsctx.IsValid() {
return rsctx, true, nil
Expand Down

0 comments on commit f99337f

Please sign in to comment.