Skip to content

Commit

Permalink
Deprecate exporters/jaeger (#4423)
Browse files Browse the repository at this point in the history
* Deprecate exporters/jaeger

* Delete jaeger example

* Remove jaeger exporter from docs

* Remove example from docs

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Revert "Delete jaeger example"

This reverts commit 1a2b47b.

* Revert "Remove example from docs"

This reverts commit 682db01.

* Add nolint comment

* Remove Jaeger from main README

* Deprecate example/jaeger

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update go.mod

* Update main.go

* fix lint

---------

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
  • Loading branch information
3 people authored Aug 15, 2023
1 parent 14b3a98 commit d78820e
Show file tree
Hide file tree
Showing 8 changed files with 36 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

### Deprecated

- The `go.opentelemetry.io/otel/exporters/jaeger` package is deprecated.
OpenTelemetry dropped support for Jaeger exporter in July 2023.
Use `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`
or `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc` instead. (#4423)
- The `go.opentelemetry.io/otel/example/jaeger` package is deprecated. (#4423)
- The `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/internal` package is deprecated. (#4420)
- The `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/internal/oconf` package is deprecated. (#4420)
- The `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/internal/otest` package is deprecated. (#4420)
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ All officially supported exporters for the OpenTelemetry project are contained i

| Exporter | Metrics | Traces |
|---------------------------------------|:-------:|:------:|
| [Jaeger](./exporters/jaeger/) | ||
| [OTLP](./exporters/otlp/) |||
| [Prometheus](./exporters/prometheus/) || |
| [stdout](./exporters/stdout/) |||
Expand Down
6 changes: 6 additions & 0 deletions example/jaeger/go.mod
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
// Deprecated: This example is no longer supported as
// [go.opentelemetry.io/otel/exporters/jaeger] is no longer supported.
// OpenTelemetry dropped support for Jaeger exporter in July 2023.
// Jaeger officially accepts and recommends using OTLP.
// Use [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp]
// or [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc] instead.
module go.opentelemetry.io/otel/example/jaeger

go 1.19
Expand Down
9 changes: 8 additions & 1 deletion example/jaeger/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@

// Command jaeger is an example program that creates spans
// and uploads to Jaeger.
//
// Deprecated: This example is no longer supported as
// [go.opentelemetry.io/otel/exporters/jaeger] is no longer supported.
// OpenTelemetry dropped support for Jaeger exporter in July 2023.
// Jaeger officially accepts and recommends using OTLP.
// Use [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp]
// or [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc] instead.
package main

import (
Expand All @@ -23,7 +30,7 @@ import (

"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/exporters/jaeger"
"go.opentelemetry.io/otel/exporters/jaeger" //nolint:staticcheck // This is deprecated and will be removed in the next release.
"go.opentelemetry.io/otel/sdk/resource"
tracesdk "go.opentelemetry.io/otel/sdk/trace"
semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
Expand Down
1 change: 0 additions & 1 deletion exporters/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ The following exporter packages are provided with the following OpenTelemetry si

| Exporter Package | Metrics | Traces |
| :-----------------------------------------------------------------------------: | :-----: | :----: |
| [go.opentelemetry.io/otel/exporters/jaeger](./jaeger) | ||
| [go.opentelemetry.io/otel/exporters/otlp/otlpmetric](./otlp/otlpmetric) || |
| [go.opentelemetry.io/otel/exporters/otlp/otlptrace](./otlp/otlptrace) | ||
| [go.opentelemetry.io/otel/exporters/prometheus](./prometheus) || |
Expand Down
6 changes: 6 additions & 0 deletions exporters/jaeger/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

[![Go Reference](https://pkg.go.dev/badge/go.opentelemetry.io/otel/exporters/jaeger.svg)](https://pkg.go.dev/go.opentelemetry.io/otel/exporters/jaeger)

> **Deprecated:** This module is no longer supported.
> OpenTelemetry dropped support for Jaeger exporter in July 2023.
> Jaeger officially accepts and recommends using OTLP.
> Use [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp](https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp)
> or [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc) instead.
[OpenTelemetry span exporter for Jaeger](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.20.0/specification/trace/sdk_exporters/jaeger.md) implementation.

## Installation
Expand Down
6 changes: 6 additions & 0 deletions exporters/jaeger/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,10 @@
// limitations under the License.

// Package jaeger contains an OpenTelemetry tracing exporter for Jaeger.
//
// Deprecated: This module is no longer supported.
// OpenTelemetry dropped support for Jaeger exporter in July 2023.
// Jaeger officially accepts and recommends using OTLP.
// Use [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp]
// or [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc] instead.
package jaeger // import "go.opentelemetry.io/otel/exporters/jaeger"
5 changes: 5 additions & 0 deletions exporters/jaeger/go.mod
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
// Deprecated: This module is no longer supported.
// OpenTelemetry dropped support for Jaeger exporter in July 2023.
// Jaeger officially accepts and recommends using OTLP.
// Use [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp]
// or [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc] instead.
module go.opentelemetry.io/otel/exporters/jaeger

go 1.19
Expand Down

0 comments on commit d78820e

Please sign in to comment.