refactor: use Key's Defined method (#2593)

* optimize(attribute): use Key's Defined method * Update kv.go
open-telemetry · Feb 11, 2022 · b01dc21 · b01dc21
1 parent 010ca4f
commit b01dc21
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/attribute/kv.go b/attribute/kv.go
@@ -26,7 +26,7 @@ type KeyValue struct {
 
 // Valid returns if kv is a valid OpenTelemetry attribute.
 func (kv KeyValue) Valid() bool {
-	return kv.Key != "" && kv.Value.Type() != INVALID
+	return kv.Key.Defined() && kv.Value.Type() != INVALID
 }
 
 // Bool creates a KeyValue with a BOOL Value type.