Skip to content

Commit

Permalink
Fix stdout TestStdoutTimestamp failure with sleep (#1572)
Browse files Browse the repository at this point in the history
* Fix stdout TestStdoutTimestamp failure with sleep

Ensure the test condition is valid by introducing minimal sleep
durations before and after a timestamp is measured.

Resolves #1571

* Add changes to changelog

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
  • Loading branch information
MrAlias and Aneurysm9 authored Feb 23, 2021
1 parent bd4701e commit 4a163be
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

- Removed attempt to resample spans upon changing the span name with `span.SetName()`. (#1545)

### Fixed

- The sequential timing check of timestamps in the stdout exporter are now setup explicitly to be sequential (#1571). (#1572)

## [0.17.0] - 2020-02-12

### Changed
Expand Down
4 changes: 4 additions & 0 deletions exporters/stdout/metric_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ func TestStdoutTimestamp(t *testing.T) {
}

before := time.Now()
// Ensure the timestamp is after before.
time.Sleep(time.Nanosecond)

checkpointSet := metrictest.NewCheckpointSet(testResource)

Expand All @@ -102,6 +104,8 @@ func TestStdoutTimestamp(t *testing.T) {
t.Fatal("Unexpected export error: ", err)
}

// Ensure the timestamp is before after.
time.Sleep(time.Nanosecond)
after := time.Now()

var printed []interface{}
Expand Down

0 comments on commit 4a163be

Please sign in to comment.