Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade kafa semconv to 1.26.0 #909

Merged
merged 11 commits into from
Jul 9, 2024
Merged

Upgrade kafa semconv to 1.26.0 #909

merged 11 commits into from
Jul 9, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 3, 2024 •
edited
Loading

Upgrade semconv from v1.24.0 to v1.26.0 in github.com/segmentio/kafka-go instrumentation.

  • The messaging.operation attribute key is renamed to messaging.operation.type.
  • The messaging.operation attribute key is renamed to messaging.operation.type.
  • The messaging.kafka.destination.partition key is renamed to messaging.destination.partition.id

Reference: semantic conventions

@MrAlias MrAlias added this to the v0.14.0-alpha milestone Jul 3, 2024
@MrAlias MrAlias marked this pull request as ready for review July 3, 2024 20:03
@MrAlias MrAlias requested a review from a team July 3, 2024 20:03
RonFed
RonFed approved these changes Jul 7, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 927dfde into open-telemetry:main Jul 9, 2024
18 checks passed
@MrAlias MrAlias deleted the semconv-v1.26.0-kafka branch July 9, 2024 00:09
@MrAlias MrAlias mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonFed RonFed RonFed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@MrAlias @RonFed