Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.2.1-alpha #158

Merged
merged 5 commits into from
May 15, 2023
Merged

Conversation

MikeGoldsmith
Copy link
Member

@MikeGoldsmith MikeGoldsmith commented May 15, 2023

Fixed

  • Fix gRPC instrumentation memory access issue on newer kernels. (#150)
  • Fix missing spans in gorillamux instrumentation. (#86)

Changed

  • Update HTTP span names to include method and route to match semantic conventions. (#143)

@MikeGoldsmith MikeGoldsmith requested a review from a team May 15, 2023 11:58
@pellared
Copy link
Member

I suggest removing the following line from changelog

- Only pull docker image if not present for the emojivoto example. ([#149](https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/149))

@pellared
Copy link
Member

pellared commented May 15, 2023

Do we have any rules saying what should be the new version number? I thought that this would rather be a 0.2.1 as there are no breaking changes.

My assumption was taken from a rule that we have in .NET auto-instrumentation: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docs/versioning.md#version-numbers-before-100
Do we want to follow a this pattern (or define a similar rule)?

@MikeGoldsmith
Copy link
Member Author

I did consider removing it from the changelog because it is not a functional change but as it didn't have skip changelog it was kept. I'm happy to remove it.

I'm also okay to set version as 0.2.1-alpha. I don't think versions mean all that much at the moment. Regarding no breaking changes, there wasn't any breaking changes when we went from 0.1 to 0.2, I think we did it to help signify the bump in compatibility (arm support) & features (gin support).

@MikeGoldsmith MikeGoldsmith changed the title Release v0.3.0-alpha Release v0.2.1-alpha May 15, 2023
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a changelog entry for this: #152?

@MrAlias
Copy link
Contributor

MrAlias commented May 15, 2023

This looks ready to merge: #154

Should we merge it before this to include it in the release?

@MikeGoldsmith
Copy link
Member Author

Happy to merge that before the release PR, but it doesn't affect the release 👍🏻

@MrAlias
Copy link
Contributor

MrAlias commented May 15, 2023

Happy to merge that before the release PR, but it doesn't affect the release 👍🏻

Merged. Can you up update this branch?

@MrAlias MrAlias merged commit 48d3c3f into open-telemetry:main May 15, 2023
@MikeGoldsmith MikeGoldsmith deleted the mike/prep-release branch May 15, 2023 16:26
MrAlias referenced this pull request in MrAlias/opentelemetry-go-instrumentation May 15, 2023
MrAlias added a commit that referenced this pull request May 15, 2023
@pellared
Copy link
Member

Regarding no breaking changes, there wasn't any breaking changes when we went from 0.1 to 0.2, I think we did it to help signify the bump in compatibility (arm support) & features (gin support).

This is not true. We did one user-facing breaking change:

- Change `OTEL_TARGET_EXE` environment variable to `OTEL_GO_AUTO_TARGET_EXE`.
([#97](https://github.com/open-telemetry/opentelemetry-go-instrumentation/issues/97))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants