-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.2.1-alpha #158
Release v0.2.1-alpha #158
Conversation
I suggest removing the following line from changelog
|
Do we have any rules saying what should be the new version number? I thought that this would rather be a My assumption was taken from a rule that we have in .NET auto-instrumentation: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docs/versioning.md#version-numbers-before-100 |
I did consider removing it from the changelog because it is not a functional change but as it didn't have skip changelog it was kept. I'm happy to remove it. I'm also okay to set version as 0.2.1-alpha. I don't think versions mean all that much at the moment. Regarding no breaking changes, there wasn't any breaking changes when we went from 0.1 to 0.2, I think we did it to help signify the bump in compatibility (arm support) & features (gin support). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a changelog entry for this: #152?
This looks ready to merge: #154 Should we merge it before this to include it in the release? |
Happy to merge that before the release PR, but it doesn't affect the release 👍🏻 |
Merged. Can you up update this branch? |
This is not true. We did one user-facing breaking change: opentelemetry-go-instrumentation/CHANGELOG.md Lines 35 to 36 in b29eef6
|
Fixed
Changed