Deprecate the sdk/telemetry package #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
changed the title
MrAlias
changed the title
MrAlias
force-pushed
the
dep-internal-telemetry
branch
3 times, most recently
from
e5634c8
to
798959b
Compare
Resolve open-telemetry#1234 The `sdk/telemetry` package is no longer used in the `auto` package since the merge of open-telemetry#1207. It is not needed outside of the `sdk` package and needs to be removed prior to stabilization of the `go.opentelemetry.io/auto/sdk` module.
MrAlias
force-pushed
the
dep-internal-telemetry
branch
from
798959b
to
05799d7
Compare
pellared
approved these changes
Nov 4, 2024
RonFed
approved these changes
Nov 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1234
Part of #1229
The
sdk/telemetrypackage is no longer used in theautopackage since the merge of #1207. It is not needed outside of thesdkpackage and needs to be removed prior to stabilization of thego.opentelemetry.io/auto/sdkmodule.We are deprecating the package instead of just removing it so the published documentation can be updated to indicate the package is deprecated.
The
internal/telemetrypackage is a one-to-one copy of thetelemetrypackage. No modification has been made.