Switch from WithSyncer to WithBatcher in examples #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
added
the
Skip Changelog
dashpole
requested review from
Aneurysm9,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo and
XSAM
as code owners
MrAlias
reviewed
Jun 15, 2021
instrumentation/github.com/Shopify/sarama/otelsarama/example/consumer/consumer.go
Outdated
Show resolved
Hide resolved
Aneurysm9
reviewed
Jun 15, 2021
instrumentation/github.com/Shopify/sarama/otelsarama/example/consumer/consumer.go
Outdated
Show resolved
Hide resolved
dashpole
force-pushed
the
syncer_examples
branch
from
c994024
to
1add62b
Compare
dashpole
force-pushed
the
syncer_examples
branch
from
1add62b
to
b86ff3f
Compare
Aneurysm9
approved these changes
Jun 16, 2021
MrAlias
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to open-telemetry/opentelemetry-go#1039, and similar to open-telemetry/opentelemetry-go#2007, but for contrib.
A user accidentally used WithSyncer in their application (though not from this example), which added extra unexplainable latency in their request path. Use WithBatcher and ForceFlush in examples to make it explicit that we are waiting for spans to be sent to stdout at each point, and to discourage the use of WithSyncer.