Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelhttp: Remove custom wrapper after handling request #6914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VirrageS
Copy link

Closes #6908

@VirrageS VirrageS requested review from dmathieu and a team as code owners March 11, 2025 10:39
@VirrageS VirrageS force-pushed the fix-handler branch 4 times, most recently from a47db8c to 25e2f1c Compare March 11, 2025 10:48
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.5%. Comparing base (3ea6585) to head (a971793).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6914     +/-   ##
=======================================
- Coverage   75.5%   75.5%   -0.1%     
=======================================
  Files        207     207             
  Lines      19319   19323      +4     
=======================================
+ Hits       14601   14602      +1     
- Misses      4283    4285      +2     
- Partials     435     436      +1     
Files with missing lines Coverage Δ
instrumentation/net/http/otelhttp/handler.go 93.0% <100.0%> (+0.1%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Janusz Marcinkiewicz <januszm@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otelhttp.NewHandler body wrapper alters default behaviour of Expect: 100-continue header handling
1 participant