-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch the semconv migration default to new #6899
Open
dmathieu
wants to merge
9
commits into
open-telemetry:main
Choose a base branch
from
dmathieu:semconv-default-dup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c76268
to
71c225f
Compare
ce8ba58
to
e8d0ac8
Compare
e8d0ac8
to
e334be7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6899 +/- ##
=======================================
- Coverage 75.5% 75.2% -0.3%
=======================================
Files 207 207
Lines 19319 19304 -15
=======================================
- Hits 14601 14535 -66
- Misses 4283 4343 +60
+ Partials 435 426 -9
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the semantic conventions migration default from the old version to be the new one, and keeps the possibility to use
http/dup
to get both.Note: we previously tested and documented an
old
config.That worked because it used the default. However, that behavior is not documented in the semconv migration spec, and allowing to keep using the old values only when the next release will entirely drop their support looks like a bad idea.
This also removes the
v1.20.0_test.go
files. Those tests rely on the global server/client, but only tests the old behavior.We can't run the old behavior only anymore, so running those would require a non-trivial refactoring that seems unneeded since this entire code will be removed in the next release.
Closes #6897