-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design document for otelhttpconv package #6859
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6859 +/- ##
=======================================
- Coverage 75.5% 75.5% -0.1%
=======================================
Files 207 207
Lines 19319 19319
=======================================
- Hits 14601 14598 -3
- Misses 4283 4285 +2
- Partials 435 436 +1 🚀 New features to boost your workflow:
|
cc @akats7 @scorpionknifes as code owners of HTTP implementations |
Co-authored-by: Robert Pająk <pellared@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an example for a certain existing HTTP instrumentation to describe how otelhttpconv
is actually being used in HTTP instrumentation? This could also give other authors more clues about how to leverage otelhttpconv
to reduce code repetition.
I've added a sample implementation of an |
This provides a design document for a new instrumentation,
otelhttpconv
that would serve as a meta instrumentation for all HTTP packages to more easily share their behavior.