Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelmongo semconv 1.21.0 bump #6272

Merged
merged 6 commits into from
Oct 28, 2024
Merged

otelmongo semconv 1.21.0 bump #6272

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b50e846
otelmongo semconv 1.24.0 bump
prestonvasquez Oct 23, 2024
9058c49
Update changelog
prestonvasquez Oct 23, 2024
6cfe6f8
Bump version to 1.21.0
prestonvasquez Oct 27, 2024
0dfede9
Move bump changelog to changed
prestonvasquez Oct 28, 2024
4b30d5d
Update changelog wording
prestonvasquez Oct 28, 2024
6ba0d60
Merge branch 'main' into otelmongo-bump-semconv
MrAlias Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Transform nil attribute values to `log.Value` zero value instead of `log.StringValue("<nil>")` in `go.opentelemetry.io/contrib/bridges/otelslog`. (#6246)
- Fix `NewClientHandler` so that `rpc.client.request.*` metrics measure requests instead of responses and `rpc.client.responses.*` metrics measure responses instead of requests in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. (#6250)
- Fix issue in `go.opentelemetry.io/contrib/config` causing `otelprom.WithResourceAsConstantLabels` configuration to not be respected. (#6260)
- Bump otelmongo semconv from 1.17.0 to 1.24.0. (#6272)

<!-- Released section -->
<!-- Don't change this section unless doing release -->
Expand Down
8 changes: 4 additions & 4 deletions instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/mongo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (

"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/codes"
semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
semconv "go.opentelemetry.io/otel/semconv/v1.24.0"
"go.opentelemetry.io/otel/trace"

"go.mongodb.org/mongo-driver/bson"
Expand All @@ -39,9 +39,9 @@ func (m *monitor) Started(ctx context.Context, evt *event.CommandStartedEvent) {
semconv.DBSystemMongoDB,
semconv.DBOperation(evt.CommandName),
semconv.DBName(evt.DatabaseName),
semconv.NetPeerName(hostname),
semconv.NetPeerPort(port),
semconv.NetTransportTCP,
semconv.NetPeerName(hostname), //nolint:staticcheck
semconv.NetPeerPort(port), //nolint:staticcheck
semconv.NetTransportTCP, //nolint:staticcheck
MrAlias marked this conversation as resolved.
Show resolved Hide resolved
}
if !m.cfg.CommandAttributeDisabled {
attrs = append(attrs, semconv.DBStatement(sanitizeCommand(evt.Command)))
Expand Down
Loading