Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelslog: Transform nil attribute to empty log.Value #6246

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

pellared
Copy link
Member

Fixes #6242

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.9%. Comparing base (32c279a) to head (6a15ea4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6246   +/-   ##
=====================================
  Coverage   66.9%   66.9%           
=====================================
  Files        190     190           
  Lines      12538   12540    +2     
=====================================
+ Hits        8393    8395    +2     
  Misses      3855    3855           
  Partials     290     290           
Files with missing lines Coverage Δ
bridges/otelslog/handler.go 96.4% <100.0%> (+<0.1%) ⬆️

@pellared pellared changed the title otelslog: Handle nil attribute value properly otelslog: Transform nil attribute value to empty log.Value Oct 14, 2024
@pellared pellared changed the title otelslog: Transform nil attribute value to empty log.Value otelslog: Transform nil attribute to empty log.Value Oct 14, 2024
@pellared pellared marked this pull request as ready for review October 14, 2024 08:31
@pellared pellared requested review from MrAlias and a team as code owners October 14, 2024 08:31
@MrAlias MrAlias added this to the v1.32.0 milestone Oct 14, 2024
@pellared pellared merged commit 0aad96e into open-telemetry:main Oct 15, 2024
24 checks passed
@pellared pellared deleted the slog-nil branch October 15, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otelslog: Handle nil values
4 participants