Implement go.schedule.duration #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
runtime_histogram
branch
from
8038b3a
to
91d530d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5991 +/- ##
=======================================
+ Coverage 65.5% 65.7% +0.2%
=======================================
Files 203 203
Lines 12985 13034 +49
=======================================
+ Hits 8506 8569 +63
+ Misses 4219 4204 -15
- Partials 260 261 +1
|
dashpole
force-pushed
the
runtime_histogram
branch
from
b5a6892
to
7dd81f3
Compare
pellared
reviewed
Aug 7, 2024
dashpole
commented
Aug 7, 2024
pellared
reviewed
Aug 8, 2024
MrAlias
reviewed
Aug 8, 2024
XSAM
reviewed
Aug 10, 2024
dashpole
force-pushed
the
runtime_histogram
branch
2 times, most recently
from
873ff8a
to
5db5299
Compare
dmathieu
approved these changes
Aug 22, 2024
dashpole
force-pushed
the
runtime_histogram
branch
from
8c2ef78
to
3e8cf67
Compare
Co-authored-by: Sam Xie <sam@samxie.me>
dashpole
force-pushed
the
runtime_histogram
branch
from
3e8cf67
to
2950bc4
Compare
XSAM
added a commit
that referenced
this pull request
Sep 11, 2024
### Added - Add `NewProducer` to `go.opentelemetry.io/contrib/instrumentation/runtime`, which allows collecting the `go.schedule.duration` histogram metric from the Go runtime. (#5991) - Add gRPC protocol support for OTLP log exporter in `go.opentelemetry.io/contrib/exporters/autoexport`. (#6083) ### Removed - Drop support for [Go 1.21]. (#6046, #6047) ### Fixed - Superfluous call to `WriteHeader` when flushing after setting a status code in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`. (#6074) - Superfluous call to `WriteHeader` when writing the response body after setting a status code in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`. (#6055) [Go 1.21]: https://go.dev/doc/go1.21 --------- Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5974.
This uses the same method for estimating the sum as the prometheus client-go: https://github.com/prometheus/client_golang/blob/46f77a97fa1e83e7285634745bd5c92c11bf20c7/prometheus/go_collector_latest.go#L543, which is to use the lower-bound of each bucket as the value of each observation.
It implements this using a metric producer. It is designed to be used together with existing runtime instrumentation.