-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isolate module #5861
base: main
Are you sure you want to change the base?
Add isolate module #5861
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5861 +/- ##
=======================================
- Coverage 64.6% 64.6% -0.1%
=======================================
Files 201 202 +1
Lines 12587 12601 +14
=======================================
+ Hits 8134 8142 +8
- Misses 4216 4221 +5
- Partials 237 238 +1
|
return p.Processor.Enabled(ctx, record) | ||
} | ||
|
||
var defaultProcessor = noopProcessor{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is another usage of an no-op processor in a processor implementation.
I think we can think about adding it the the SDK.
See also: #5817 (comment)
EDIT: I created open-telemetry/opentelemetry-go#5580
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me this is needed currently. We still do not comply with specification regarding our log record type begin passed to the log processor: open-telemetry/opentelemetry-go#5219. The resolution of that may make this type of log processor redundant and unneeded.
I would prefer we resolve prior to adding this kind of extension.
Even if the processor would to accept a fully mutable record - this processor would still be helpful. However, we can postpone this if this is your preference, then please move it to "blocked". |
With our changes and this still pending, I would prefer to not add this as it has a good potential to be cruft. |
Blocked by:
Fixes #5823
Benchmark results: