Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert toolchain addition to autoexport #5841

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 2, 2024

Reverts changes introduced in #5779. Drops the toolchain directive in go.mod. This addition adds project wide issues
(https://github.com/open-telemetry/opentelemetry-go-contrib/actions/runs/9765870369/job/26957555908?pr=5839).

If toolchains are going to be used, they need to be added project wide.

Reverts changes introduced in #5779. Drops the toolchain directive in
go.mod. This addition adds project wide issues
(https://github.com/open-telemetry/opentelemetry-go-contrib/actions/runs/9765870369/job/26957555908?pr=5839).

If toolchains are going to be used, they need to be added project wide.
@MrAlias MrAlias added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jul 2, 2024
@MrAlias MrAlias marked this pull request as ready for review July 2, 2024 18:12
@MrAlias MrAlias requested a review from pellared as a code owner July 2, 2024 18:12
@MrAlias MrAlias requested a review from a team July 2, 2024 18:12
@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 2, 2024

Merging early as this is trivial and blocking other PRs.

@MrAlias MrAlias merged commit 1ce0d1c into open-telemetry:main Jul 2, 2024
25 checks passed
@MrAlias MrAlias deleted the fix-5779 branch July 2, 2024 19:42
@MrAlias MrAlias added this to the v1.28.0 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants