Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement http.Hijacker for otelmux #5796

Closed
wants to merge 0 commits into from
Closed

Implement http.Hijacker for otelmux #5796

wants to merge 0 commits into from

Conversation

rehanpfmr
Copy link
Contributor

Issue: #5402

@rehanpfmr rehanpfmr requested a review from a team June 24, 2024 05:55
dmathieu
dmathieu reviewed Jun 24, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
instrumentation/github.com/gorilla/mux/otelmux/mux.go Outdated Show resolved Hide resolved
@dmathieu dmathieu changed the title Fix Middleware support websockets Implement http.Hijacker for otelmux Jun 24, 2024
MrAlias
MrAlias reviewed Jun 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias added the response needed Waiting on user input before progress can be made label Jul 9, 2024
@rehanpfmr
Copy link
Contributor Author

I will be adding test case shortly for this.
thanks

@rehanpfmr
Copy link
Contributor Author

@dmathieu , Added test case, please review.
thanks.

@rehanpfmr
Copy link
Contributor Author

@dmathieu , I have updated the test for otelmux, would you please review?

@codecov Codecov
Copy link

codecov bot commented Aug 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.4%. Comparing base (dc311ec) to head (9359996).
Report is 8 commits behind head on main.

Files Patch % Lines
...trumentation/github.com/gorilla/mux/otelmux/mux.go 0.0% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5796     +/-   ##
=======================================
- Coverage   65.5%   65.4%   -0.1%     
=======================================
  Files        203     203             
  Lines      12984   12988      +4     
=======================================
  Hits        8505    8505             
- Misses      4219    4223      +4     
  Partials     260     260
Files Coverage Δ
...trumentation/github.com/gorilla/mux/otelmux/mux.go 85.3% <0.0%> (-4.1%) ⬇️

dmathieu
dmathieu reviewed Aug 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
instrumentation/github.com/gorilla/mux/otelmux/test/mux_test.go Outdated Show resolved Hide resolved
instrumentation/github.com/gorilla/mux/otelmux/test/mux_test.go Outdated Show resolved Hide resolved
dmathieu
dmathieu reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instrgen/driver/driver should not be modified in this PR.

CHANGELOG.md Outdated Show resolved Hide resolved
instrumentation/github.com/gorilla/mux/otelmux/test/mux_test.go Outdated Show resolved Hide resolved
@rehanpfmr
Copy link
Contributor Author

rehanpfmr commented Sep 7, 2024 •
edited
Loading

I will have gofumpt on the errors also, drop the 'instrgen/driver/driver' changes and force push the changes.

@rehanpfmr rehanpfmr closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias left review comments

@dmathieu dmathieu dmathieu left review comments

Assignees
No one assigned
Labels
response needed Waiting on user input before progress can be made
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rehanpfmr @dmathieu @MrAlias