Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelzap: Allow context injection via fields #5707

Merged
merged 13 commits into from
Jun 4, 2024
Merged

otelzap: Allow context injection via fields #5707

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cc51737
zap context
khushijain21 Jun 1, 2024
e174da6
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
khushijain21 Jun 1, 2024
23ab6d3
zap ctx
khushijain21 Jun 3, 2024
01c9d55
remove test
khushijain21 Jun 3, 2024
48524de
code refactor
khushijain21 Jun 3, 2024
3ccf3fb
zap context
khushijain21 Jun 3, 2024
2c87ebc
Update bridges/otelzap/core_test.go
khushijain21 Jun 3, 2024
b4c8425
Update bridges/otelzap/core.go
khushijain21 Jun 3, 2024
5e20a77
Update bridges/otelzap/core.go
khushijain21 Jun 3, 2024
f59e941
not use ctx as param
khushijain21 Jun 3, 2024
5e31422
Update core_test.go
pellared Jun 3, 2024
26b0018
Update core.go
khushijain21 Jun 3, 2024
e7279f2
Merge branch 'main' into zapctx
pellared Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update bridges/otelzap/core_test.go 
Co-authored-by: Robert Pająk <pellared@hotmail.com>
  • Loading branch information
@khushijain21 @pellared
khushijain21 and pellared authored Jun 3, 2024
commit 2c87ebce0644def538843d5be581cb1d48208df8
4 changes: 2 additions & 2 deletions bridges/otelzap/core_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ func TestCore(t *testing.T) {

rec.Reset()

// TODO WriteContext
// TOOD WithContext
// TODO: Add WriteContext test case
// TOOD: Add WithContext test case

// test child logger with accumulated fields
t.Run("With", func(t *testing.T) {
Expand Down
Loading