Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelzap: Implement Enabled method #5594

Merged
merged 8 commits into from
May 17, 2024
Merged

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented May 16, 2024

Part of #5191

Pre-work #5279

This PR implements Enabled method on Core

@khushijain21 khushijain21 requested a review from a team May 16, 2024 09:03
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.2%. Comparing base (6d343e9) to head (f3b63d4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5594     +/-   ##
=======================================
- Coverage   63.2%   63.2%   -0.1%     
=======================================
  Files        194     194             
  Lines      11956   11958      +2     
=======================================
  Hits        7558    7558             
- Misses      4182    4183      +1     
- Partials     216     217      +1     
Files Coverage Δ
bridges/otelzap/core.go 92.9% <100.0%> (+0.2%) ⬆️

... and 1 file with indirect coverage changes

bridges/otelzap/core.go Outdated Show resolved Hide resolved
bridges/otelzap/core_test.go Outdated Show resolved Hide resolved
@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label May 16, 2024
khushijain21 and others added 2 commits May 16, 2024 15:07
Co-authored-by: Robert Pająk <pellared@hotmail.com>
bridges/otelzap/core_test.go Outdated Show resolved Hide resolved
bridges/otelzap/core_test.go Show resolved Hide resolved
khushijain21 and others added 2 commits May 16, 2024 16:13
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@pellared pellared merged commit 6646038 into open-telemetry:main May 17, 2024
23 checks passed
zailic pushed a commit to zailic/opentelemetry-go-contrib that referenced this pull request May 20, 2024
Part of open-telemetry#5191
---------
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants