Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a host resource detector #5399
base: main
Are you sure you want to change the base?
Add a host resource detector #5399
Changes from 4 commits
21c8ab8
605afe8
4c5d456
055f721
c32b3ed
3cfd6e8
b00dc6d
2ca2dca
0c16b70
2a98f05
d976eeb
2a14b6f
20a8a67
8b7b4d5
15ae5a8
c1ac4e7
1fe6385
ffa6502
b0e92eb
f585990
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 111 in detectors/host/host.go
Codecov / codecov/patch
detectors/host/host.go#L111
Check warning on line 17 in detectors/host/host_id_linux.go
Codecov / codecov/patch
detectors/host/host_id_linux.go#L17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error should not be ignored. The test should be failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adapted the tests so that the
host.name
is only added to the list of expected attributes whenos.Hostname()
doesn't return an error.This covers cases where
os.Hostname()
returns an error, but ahost.id
might still be obtained.I'm happy to both make the tests and detector logic fail when
os.Hostname()
fails, if folks think that's better.