Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelgrpc: Add peer attributes to spans generated by stats handlers #4873

Merged
merged 4 commits into from
Jan 30, 2024
Merged

otelgrpc: Add peer attributes to spans generated by stats handlers #4873

merged 4 commits into from
Jan 30, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Jan 29, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bfae9a3) 81.3% compared to head (23e57ea) 81.3%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4873   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files        151     151           
  Lines      10890   10894    +4     
=====================================
+ Hits        8862    8866    +4     
  Misses      1869    1869           
  Partials     159     159
Files Coverage Δ
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 100.0% <100.0%> (ø)

@pellared pellared marked this pull request as ready for review January 29, 2024 13:13
@pellared pellared requested a review from a team January 29, 2024 13:13
@pellared
Copy link
Member Author

FYI @fatsheep9146

@pellared pellared mentioned this pull request Jan 29, 2024
Closed
fatsheep9146
fatsheep9146 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@fatsheep9146 fatsheep9146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pellared pellared merged commit ef8063b into open-telemetry:main Jan 30, 2024
22 checks passed
@pellared pellared deleted the grpc-peer-attrs branch January 30, 2024 15:52
@MrAlias MrAlias mentioned this pull request Feb 6, 2024
Merged
@MrAlias MrAlias added this to the v0.48.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@MrAlias MrAlias MrAlias approved these changes

@dashpole dashpole dashpole approved these changes

@dmathieu dmathieu dmathieu approved these changes

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.23.0/v0.48.0/v0.17.0/v0.3.0
Development

Successfully merging this pull request may close these issues.

otelgrpc: Add peer attributes to spans generated by stats handlers
5 participants
@pellared @dmathieu @dashpole @MrAlias @fatsheep9146