otelgrpc: Stablize TestInterceptors #4535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352
The problem is that
StreamClientInterceptor
ends the spans asynchronously:opentelemetry-go-contrib/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go
Lines 305 to 319 in b44dfc9
It may seem that it would be better to reimplement
StreamClientInterceptor
. However, I do not find it pragmatic given that we want to deprecate the interceptors anyway.EDIT: I think I have implemented a fix for the
StreamClientInterceptor
here: #4537.