Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgrpc: Set "rpc.server.duration" metric description #4302

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

puckpuck
Copy link
Contributor

Fixes #4301

This sets the description for the rpc.server.duration metric. This description is set as defined by the semantic convention for this metric.

When used with other services written in other languages that emit the same metric, all services must emit the same metric metadata (name, description) when used in conjunction with a Prometheus backend. The OpenTelemetry Collector, Prometheus exporter, will drop metrics that match the name but not the description against already received metrics. We have faced this problem as part of the OpenTelemetry demo project.

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #4302 (1e3080b) into main (da0d2ea) will increase coverage by 0.0%.
The diff coverage is 75.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4302   +/-   ##
=====================================
  Coverage   81.9%   81.9%           
=====================================
  Files        141     141           
  Lines       9708    9711    +3     
=====================================
+ Hits        7960    7963    +3     
  Misses      1616    1616           
  Partials     132     132           
Files Changed Coverage
...entation/google.golang.org/grpc/otelgrpc/config.go 75.0%

@pellared pellared changed the title [grpc] set rpc.server.duration metric description otelgrpc: Set "rpc.server.duration" metric description Sep 18, 2023
@pellared pellared merged commit f44f5ad into open-telemetry:main Sep 18, 2023
23 of 24 checks passed
@puckpuck puckpuck deleted the grpc-fix-metric-description branch September 18, 2023 11:12
@MrAlias MrAlias added this to the v1.20.0/v0.45.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpc.server.duration metric does not have a description
6 participants