-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ProbabilitySampler
-> ParentBased
in examples
#3387
base: main
Are you sure you want to change the base?
Conversation
Update the examples to use the current API for configuring production sampling. These names were changed a couple of years ago. open-telemetry/opentelemetry-go#1115 open-telemetry/opentelemetry-go#1153
|
ProbabilitySampler
-> ParentBased
ProbabilitySampler
-> ParentBased
in examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this definitely makes sense, I wonder if we could make the doc more helpful with a link to https://opentelemetry.io/docs/instrumentation/go/exporting_data/#sampling?
Good idea. Updated the comments to include the link - 8daebcc |
open-telemetry/opentelemetry-go#3585 changed the location of the sampling documentation. It changed from https://opentelemetry.io/docs/instrumentation/go/exporting_data/#sampling -> https://opentelemetry.io/docs/instrumentation/go/sampling/. I'll update the link in the comments - 18970fd. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3387 +/- ##
========================================
+ Coverage 69.6% 86.2% +16.6%
========================================
Files 147 4 -143
Lines 6919 124 -6795
========================================
- Hits 4821 107 -4714
+ Misses 1978 14 -1964
+ Partials 120 3 -117 |
Update the examples to use the current API for configuring production sampling.
These names were changed a couple of years ago:
open-telemetry/opentelemetry-go#1115
open-telemetry/opentelemetry-go#1153