-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelmux: Add new WithSpanNameFormatter option #3041
otelmux: Add new WithSpanNameFormatter option #3041
Conversation
8aed053
to
9e2f09a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a changelog entry.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3041 +/- ##
=====================================
Coverage 69.0% 69.0%
=====================================
Files 147 147
Lines 6875 6884 +9
=====================================
+ Hits 4745 4752 +7
- Misses 2011 2014 +3
+ Partials 119 118 -1
|
455babb
to
1fb06e0
Compare
241e457
to
9899b15
Compare
I've rebased - can I get a re-review? |
9899b15
to
3d89e36
Compare
thanks for the approval @dmathieu 🙇♂️ |
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
3d89e36
to
3608476
Compare
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
3608476
to
08d3435
Compare
@dmathieu Any idea what's remaining to get this merged? |
Thanks @MadVikingGod 🙇♂️ |
Fixes #3040
Signed-off-by: Dave Henderson dhenderson@gmail.com