Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelmux: Add new WithSpanNameFormatter option #3041

Conversation

hairyhenderson
Copy link
Contributor

Fixes #3040

Signed-off-by: Dave Henderson dhenderson@gmail.com

Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a changelog entry.

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #3041 (3d89e36) into main (3e6928d) will increase coverage by 0.0%.
The diff coverage is 80.0%.

❗ Current head 3d89e36 differs from pull request most recent head 08d3435. Consider uploading reports for the commit 08d3435 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3041   +/-   ##
=====================================
  Coverage   69.0%   69.0%           
=====================================
  Files        147     147           
  Lines       6875    6884    +9     
=====================================
+ Hits        4745    4752    +7     
- Misses      2011    2014    +3     
+ Partials     119     118    -1     
Impacted Files Coverage Δ
...trumentation/github.com/gorilla/mux/otelmux/mux.go 87.0% <75.0%> (+0.8%) ⬆️
...mentation/github.com/gorilla/mux/otelmux/config.go 100.0% <100.0%> (ø)
instrumentation/net/http/otelhttp/config.go 80.3% <0.0%> (-7.6%) ⬇️
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 83.9% <0.0%> (+0.9%) ⬆️

@hairyhenderson hairyhenderson force-pushed the otelmux-configurable-spanNameFormatter-3040 branch 2 times, most recently from 455babb to 1fb06e0 Compare November 29, 2022 23:41
@hairyhenderson hairyhenderson force-pushed the otelmux-configurable-spanNameFormatter-3040 branch from 241e457 to 9899b15 Compare December 5, 2022 20:45
@hairyhenderson
Copy link
Contributor Author

I've rebased - can I get a re-review?

@hairyhenderson hairyhenderson force-pushed the otelmux-configurable-spanNameFormatter-3040 branch from 9899b15 to 3d89e36 Compare December 7, 2022 03:26
@hairyhenderson
Copy link
Contributor Author

thanks for the approval @dmathieu 🙇‍♂️

Signed-off-by: Dave Henderson <dhenderson@gmail.com>
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
@hairyhenderson hairyhenderson force-pushed the otelmux-configurable-spanNameFormatter-3040 branch from 3d89e36 to 3608476 Compare December 14, 2022 12:56
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
@hairyhenderson hairyhenderson force-pushed the otelmux-configurable-spanNameFormatter-3040 branch from 3608476 to 08d3435 Compare December 14, 2022 12:57
@hairyhenderson
Copy link
Contributor Author

@dmathieu Any idea what's remaining to get this merged?

@MadVikingGod MadVikingGod merged commit bb73de9 into open-telemetry:main Dec 15, 2022
@hairyhenderson hairyhenderson deleted the otelmux-configurable-spanNameFormatter-3040 branch December 15, 2022 16:36
@hairyhenderson
Copy link
Contributor Author

Thanks @MadVikingGod 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otelmux: Add config option for a custom span name formatter
3 participants