Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelhttp.WithRouteTag does not set route tag for metrics #611

Closed
charleskorn opened this issue Mar 9, 2021 · 0 comments · Fixed by #615
Closed

otelhttp.WithRouteTag does not set route tag for metrics #611

charleskorn opened this issue Mar 9, 2021 · 0 comments · Fixed by #615
Labels
bug Something isn't working instrumentation: otelhttp

Comments

@charleskorn
Copy link
Contributor

I expected otelhttp.WithRouteTag() to set the route tag for both traces and metrics, but it appears to only set the route tag for traces.

Happy to submit a PR to add this to WithRouteTag() using the functionality added in #306 if this would be reasonable default behaviour.
charleskorn added a commit to charleskorn/opentelemetry-go-contrib that referenced this issue Mar 14, 2021
@charleskorn
Add route tag to metrics as well as traces when using WithRouteTag.
ba3159b 
Resolves open-telemetry#611.
@charleskorn charleskorn mentioned this issue Mar 14, 2021
Merged
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@owais
Updated default port for OTLP exporter (#611)
446727b 
OpenCensus used `55678` as the default. OTLP used `55680`. This commit fixes the incorrect default port specified for the OTLP exporter.
@MrAlias MrAlias added bug Something isn't working instrumentation: otelhttp labels Nov 2, 2022
charleskorn added a commit to charleskorn/opentelemetry-go-contrib that referenced this issue Nov 19, 2022
@charleskorn
Add route tag to metrics as well as traces when using WithRouteTag.
a28312d 
Resolves open-telemetry#611.
charleskorn added a commit to charleskorn/opentelemetry-go-contrib that referenced this issue Nov 19, 2022
@charleskorn
Add route tag to metrics as well as traces when using WithRouteTag.
bc2b009 
Resolves open-telemetry#611.
charleskorn added a commit to charleskorn/opentelemetry-go-contrib that referenced this issue May 28, 2023
@charleskorn
Add route tag to metrics as well as traces when using WithRouteTag.
4e27aed 
Resolves open-telemetry#611.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working instrumentation: otelhttp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WithRouteTag adds HTTP route attribute to metrics charleskorn/opentelemetry-go-contrib
2 participants
@charleskorn @MrAlias