Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Otel HTTP produce old and new Client Metrics #5973

Closed
1 of 2 tasks
MadVikingGod opened this issue Aug 2, 2024 · 2 comments
Closed
1 of 2 tasks

Make Otel HTTP produce old and new Client Metrics #5973

MadVikingGod opened this issue Aug 2, 2024 · 2 comments
Assignees
@VinozzZ

Comments

@MadVikingGod
Copy link
Contributor

MadVikingGod commented Aug 2, 2024 •
edited by MrAlias
Loading

Make instrumentation/net/http/otelhttp produce Client Metrics following the migration plan #5132.

A user should be able to produce Metrics from the transport in current semconv (default), and the latest semconv (1.26.0) based on the Environment variable OTEL_HTTP_CLIENT_COMPATIBILITY_MODE
@MadVikingGod MadVikingGod mentioned this issue Aug 2, 2024
Closed
5 tasks
@MrAlias
Copy link
Contributor

MrAlias commented Aug 8, 2024

@VinozzZ is working on the old client metrics.

@VinozzZ VinozzZ mentioned this issue Aug 8, 2024
Merged
dmathieu added a commit that referenced this issue Oct 10, 2024
@VinozzZ @dashpole @dmathieu
feat(instrumentation/http/otelhttp): move client metrics creation int…
87d0229 
…o internal semconv package (#6002)

In preparation for implementing `OTEL_SEMCONV_STABILITY_OPT_IN` for HTTP
client metrics, this is the first PR to emit only old client metrics.
This PR will enable us to add the ability for otelhttp to emit both old
and new client metrics.

Address issue #5973

---------

Co-authored-by: David Ashpole <dashpole@google.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
@MrAlias
Copy link
Contributor

MrAlias commented Oct 17, 2024

Closing. Going to track remaining work in a dedicated issue.

@MrAlias MrAlias closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VinozzZ VinozzZ

Labels
None yet
Projects
Go: HTTP Semconv Migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MadVikingGod @MrAlias @VinozzZ