Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Redaction to otelhttp #3895

Open
fpozzobon opened this issue Jun 1, 2023 · 1 comment
Open

Add Redaction to otelhttp #3895

fpozzobon opened this issue Jun 1, 2023 · 1 comment
Labels
enhancement New feature or request instrumentation: otelhttp

Comments

@fpozzobon
Copy link

Problem Statement

Some attributes passed to attributes might contain sensitive data (example: http.url)

Proposed Solution

As a consumer of the library, it would be great to have possibility to apply redaction (masking value) to a defined set of attributes.

Alternatives

In place of redaction we could:

  1. Apply a filter option which would dismiss the attributes
  2. Apply an option which would enable consumer to define request/response attributes

Prior Art

Redaction option already exists for header

Additional Context

To be compliant with GDPR, it is important for consumer of the library to have the possibility to mask attribute values
@fpozzobon fpozzobon added area: instrgen Related to the instrgen package enhancement New feature or request labels Jun 1, 2023
fpozzobon pushed a commit to fpozzobon/opentelemetry-go-contrib that referenced this issue Jun 1, 2023
Add redaction to request / response
c3c0ad0 
Adding redaction option to request and response so consumer of the library can hide sensitive values

References: open-telemetry#3895
@fpozzobon fpozzobon mentioned this issue Jun 1, 2023
Closed
fpozzobon pushed a commit to fpozzobon/opentelemetry-go-contrib that referenced this issue Jun 1, 2023
Add redaction to request / response
d70239f 
Adding redaction option to request and response so consumer of the library can hide sensitive values

References: open-telemetry#3895
fpozzobon pushed a commit to fpozzobon/opentelemetry-go-contrib that referenced this issue Jun 1, 2023
Add redaction to request / response
71b8100 
Adding redaction option to request and response so consumer of the library can hide sensitive values

References: open-telemetry#3895
fpozzobon added a commit to fpozzobon/opentelemetry-go-contrib that referenced this issue Jun 1, 2023
@fpozzobon
Add redaction to request / response
2cd4baf 
Adding redaction option to request and response so consumer of the library can hide sensitive values

References: open-telemetry#3895
@fpozzobon fpozzobon mentioned this issue Jun 1, 2023
Open
@dmathieu
Copy link
Member

dmathieu commented Jun 2, 2023

Related, for mongo: #3662

I wonder if it wouldn't be good to start an otep on this, so every SDK can use similar approaches.

@MrAlias MrAlias added instrumentation: otelhttp and removed area: instrgen Related to the instrgen package labels Jun 13, 2023
@pellared pellared mentioned this issue Aug 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request instrumentation: otelhttp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmathieu @MrAlias @fpozzobon