Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Cortex exporter test panics #310

Closed
MrAlias opened this issue Aug 27, 2020 · 6 comments
Closed

Investigate Cortex exporter test panics #310

MrAlias opened this issue Aug 27, 2020 · 6 comments
Assignees
Labels
area: exporter Related to an exporter package bug Something isn't working
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Aug 27, 2020

https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-go-contrib/814/workflows/0312cefe-6305-4bf6-aac5-410ba6a5e5cc/jobs/1444

Looks like a timeout is causing the testing to panic after 30 seconds. Can this behavior be designed away otherwise it should be tuned to not panic.

@MrAlias MrAlias added bug Something isn't working area: exporter Related to an exporter package release:required-for-ga labels Aug 27, 2020
@evantorrie
Copy link
Contributor

This always seems to be for the 386 build only. Profiling it shows 90+% of the time in math/big.addMulVVW which is part of the crypto random number generation for the CA cert, server cert and client key/cert.

@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 27, 2020

Might be related to golang/go#22643

@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 27, 2020

From the SIG meeting today we talked about making the certs static and storing in a testdata directory that is checked in.

MrAlias referenced this issue in MrAlias/opentelemetry-go-contrib Aug 27, 2020
Temporary fix while #310 is addressed.
MrAlias added a commit that referenced this issue Aug 27, 2020
Temporary fix while #310 is addressed.
@evantorrie
Copy link
Contributor

I think this has been addressed already, but an alternative would be to drop the number of bits in the RSA private key generation. Dropping from 4096 to 1024 bits improves runtime by around two orders of magnitude on my machine.

@ercl
Copy link
Contributor

ercl commented Aug 29, 2020

Thanks for that tip! I didn't think lowering it to 1024 would improve performance so much. While I was testing that out, I also tried using ECDSA P256 and I ended up changing the key generation functions to use that since it seems to have even better performance than RSA 1024. I added some of my results from pprof on my PR comment.

@ercl
Copy link
Contributor

ercl commented Sep 9, 2020

I think this issue this can be closed since it was resolved by #315.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: exporter Related to an exporter package bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants