Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmark and integration testing for grpc instrumentation. #217

Closed
MrAlias opened this issue Aug 13, 2020 · 0 comments · Fixed by #297
Closed

Add benchmark and integration testing for grpc instrumentation. #217

MrAlias opened this issue Aug 13, 2020 · 0 comments · Fixed by #297
Assignees
@MrAlias
Labels
area: instrumentation Related to an instrumentation package
Milestone
RC1

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Aug 13, 2020

This testing and benchmarking is needed prior to any of the follow-on work for the gRPC instrumentation (#197 and #194).

Looks like we can use the grpc_testing package for this.
@MrAlias MrAlias added area: instrumentation Related to an instrumentation package release:required-for-ga labels Aug 13, 2020
@MrAlias MrAlias self-assigned this Aug 13, 2020
This was referenced Aug 25, 2020
Merged
Merged
@MrAlias MrAlias added this to the RC1 milestone Sep 3, 2020
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@paivagustavo @rghetia
change key to a string alias and KeyValue constructors (#217)
5e409de 
* change key to a string alias and KeyValue constructors

* fix int and uint tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area: instrumentation Related to an instrumentation package
Projects
None yet
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

Add integration testing for gRPC instrumentation MrAlias/opentelemetry-go-contrib
1 participant
@MrAlias