Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gRPC instrumentation #194

Open
3 of 4 tasks
MrAlias opened this issue Jul 27, 2020 · 2 comments
Open
3 of 4 tasks

Update gRPC instrumentation #194

MrAlias opened this issue Jul 27, 2020 · 2 comments
Assignees
@MrAlias
Labels
area: instrumentation Related to an instrumentation package instrumentation: otelgrpc

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jul 27, 2020

The gRPC instrumentation ...

  • should include metric instruments to capture metric events.
  • rename to not include trace in name. Likely want to follow the naming standards from the contrib instrumentation: go.opentelemetry.io/otel/instrumentation/google.golang.org/grpc (though IIRC there are more than one gRPC libraries this works with 🤷).
  • make into its own Go module to separate it from the go.opentelemetry.io/otel (specifically go.opentelemetry.io/otel/api) package.
  • investigate if this should be moved to the contrib repository.
@MrAlias MrAlias self-assigned this Jul 27, 2020
@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 27, 2020

Relates to open-telemetry/opentelemetry-go#940 (breaking into own package).

MrAlias referenced this issue in MrAlias/opentelemetry-go-contrib Aug 4, 2020
@MrAlias
Add google.golang.org/grpc instrumentation from otel repo
58c0e40 
Move the existing grpctrace package from the go.opentelemetry.io/otel
repository to here. This is based on the package last modified in:
96a5f8f

This is related to:
https://github.com/open-telemetry/opentelemetry-go/issues/976
MrAlias referenced this issue in MrAlias/opentelemetry-go Aug 4, 2020
@MrAlias
Remove grpctrace package
03ad6e6 
This is being moved to the contrib repo with
open-telemetry/opentelemetry-go-contrib#189
as part of #976.
MrAlias referenced this issue Aug 6, 2020
@MrAlias
Move gRPC instrumentation from go.opentelemetry.io/otel (#189)
87806b1 
* Add google.golang.org/grpc instrumentation from otel repo

Move the existing grpctrace package from the go.opentelemetry.io/otel
repository to here. This is based on the package last modified in:
96a5f8f

This is related to:
https://github.com/open-telemetry/opentelemetry-go/issues/976

* Update package name: grpctrace -> grpc

* Revert back to the v0.10.0 api/standard package for now

* Make into Go module

* Update the Changelog

* Move the gRPC example from otel

Taken from the otel repository at
5438916

* Update packaging of example

* Update go.sum for example

* Add grpc instrumentation to dependabot config
MrAlias referenced this issue in open-telemetry/opentelemetry-go Aug 6, 2020
@MrAlias
Move grpctrace to contrib repo (#1027)
f0620dc 
* Remove grpctrace package

This is being moved to the contrib repo with
open-telemetry/opentelemetry-go-contrib#189
as part of #976.

* Update Changelog

* Remove the grpc example

Moved to contrib repo

* Fix spelling error

* Update Changelog
@MrAlias MrAlias transferred this issue from open-telemetry/opentelemetry-go Aug 6, 2020
@MrAlias MrAlias added area: instrumentation Related to an instrumentation package release:required-for-ga labels Aug 6, 2020
@MrAlias MrAlias mentioned this issue Aug 6, 2020
Closed
@MrAlias MrAlias mentioned this issue Aug 13, 2020
Closed
@MrAlias MrAlias added this to the RC1 milestone Sep 3, 2020
@brian-groux-hs
Copy link

Would be great to ensure the new instrumentation also covers off any metrics that are currently available here: https://github.com/grpc-ecosystem/go-grpc-prometheus

@yegle yegle mentioned this issue Nov 4, 2020
Closed
@MrAlias MrAlias removed this from the RC1 milestone Feb 18, 2021
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@agneum @rghetia
SDK: Add benchmark test for W3C TraceContext Inject/Extract (#194)
14c4216 
* SDK: Add benchmark test for W3C TraceContext Inject/Extract

* SDK: benchmark TraceContext: remove global tracer

* SDK: Add benchmarks for TraceContext: rename methods
@mabdh mabdh mentioned this issue Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area: instrumentation Related to an instrumentation package instrumentation: otelgrpc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrAlias @brian-groux-hs