Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multimod: ignore excluded-modules when -a flag is enabled #442

Merged

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Nov 22, 2023

This allows users of the sync command to sync all modules in a monorepo, including those listed in the excluded-modules. This is useful for repositories where some modules may not yet be ready for releasing (therefore listed under excluded-modules) but their dependencies still need to be managed via multimod.

Alex Boten added 3 commits November 22, 2023 09:00
This flag allows users of the `sync` command to sync all modules in a monorepo, including those listed in the excluded-modules. This is useful for repositories where some modules may not yet be ready for releasing (therefore listed under excluded-modules) but their dependencies still need to be managed via multimod.

Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten marked this pull request as ready for review November 22, 2023 22:25
@codeboten codeboten requested review from a team and jpkrohling November 22, 2023 22:25
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (49952c1) 63.51% compared to head (63a96fe) 63.65%.

Files Patch % Lines
multimod/internal/sync/sync.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   63.51%   63.65%   +0.14%     
==========================================
  Files          39       39              
  Lines        2250     2259       +9     
==========================================
+ Hits         1429     1438       +9     
  Misses        677      677              
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this flag? Is there any reason why it shouldn't we simply change the behavior without introducing the flag?

@codeboten
Copy link
Contributor Author

Do we need this flag? Is there any reason why it shouldn't we simply change the behavior without introducing the flag?

It's a good question, I didn't want to assume that all users would benefit from this change, but thinking back on it, maybe it is desirable for all users to update sync deps even for excluded modules. I could go either ways with this.

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten changed the title multimod: add ignore-excluded flag multimod: ignore excluded-modules when -a flag is enabled Nov 23, 2023
@codeboten codeboten changed the title multimod: ignore excluded-modules when -a flag is enabled multimod: ignore excluded-modules when -a flag is enabled Nov 23, 2023
@codeboten
Copy link
Contributor Author

@pellared after re-thinking this, I changed the behaviour for anyone that uses the -a flag

@codeboten codeboten merged commit 0ec5f4b into open-telemetry:main Nov 24, 2023
10 checks passed
@codeboten codeboten deleted the codeboten/add-ignore-excluded branch November 24, 2023 15:58
@pellared pellared mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants