-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multimod: ignore excluded-modules
when -a
flag is enabled
#442
multimod: ignore excluded-modules
when -a
flag is enabled
#442
Conversation
This flag allows users of the `sync` command to sync all modules in a monorepo, including those listed in the excluded-modules. This is useful for repositories where some modules may not yet be ready for releasing (therefore listed under excluded-modules) but their dependencies still need to be managed via multimod. Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
+ Coverage 63.51% 63.65% +0.14%
==========================================
Files 39 39
Lines 2250 2259 +9
==========================================
+ Hits 1429 1438 +9
Misses 677 677
Partials 144 144 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this flag? Is there any reason why it shouldn't we simply change the behavior without introducing the flag?
It's a good question, I didn't want to assume that all users would benefit from this change, but thinking back on it, maybe it is desirable for all users to update sync deps even for excluded modules. I could go either ways with this. |
Signed-off-by: Alex Boten <aboten@lightstep.com>
excluded-modules
when -a
flag is enabled
@pellared after re-thinking this, I changed the behaviour for anyone that uses the -a flag |
This allows users of the
sync
command to sync all modules in a monorepo, including those listed in the excluded-modules. This is useful for repositories where some modules may not yet be ready for releasing (therefore listed under excluded-modules) but their dependencies still need to be managed via multimod.