Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the --ignore flag to dbotconf #363

Merged
merged 8 commits into from
Jul 17, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 12, 2023

Example use:

dbotconf --ignore "/LICENSES" generate

Resolves #362 (verified locally)

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 58.33% and project coverage change: -0.40 ⚠️

Comparison is base (35e6027) 60.83% compared to head (26c6685) 60.43%.

❗ Current head 26c6685 differs from pull request most recent head 908e611. Consider uploading reports for the commit 908e611 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   60.83%   60.43%   -0.40%     
==========================================
  Files          49       49              
  Lines        2298     2328      +30     
==========================================
+ Hits         1398     1407       +9     
- Misses        750      770      +20     
- Partials      150      151       +1     
Impacted Files Coverage Δ
dbotconf/internal/cmd.go 0.00% <0.00%> (ø)
dbotconf/internal/generate.go 71.79% <40.00%> (-4.92%) ⬇️
dbotconf/internal/verify.go 78.21% <40.00%> (-4.08%) ⬇️
internal/repo/repo.go 62.16% <70.00%> (+0.87%) ⬆️
dbotconf/internal/mods.go 60.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MrAlias MrAlias marked this pull request as ready for review July 12, 2023 22:06
@MrAlias MrAlias requested review from a team and codeboten July 12, 2023 22:06
@MrAlias MrAlias force-pushed the add-ignore-dbotconf branch from 3ee63b1 to 904a960 Compare July 13, 2023 15:04
internal/repo/repo.go Show resolved Hide resolved
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, non-blocking comment about the flag docs

dbotconf/internal/cmd.go Outdated Show resolved Hide resolved
MrAlias and others added 2 commits July 17, 2023 07:21
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
@MrAlias MrAlias merged commit 071539a into open-telemetry:main Jul 17, 2023
@MrAlias MrAlias deleted the add-ignore-dbotconf branch July 17, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ignore flag to dbotconf
4 participants