Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update dependabot pr script #235

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Jan 25, 2023

This removes the need for the "Skip changelog" label and update the title to contain "[chore]". This works around the issue that opentelemetrybot doesnt have permission to edit a PR and add a label to it.

Signed-off-by: Alex Boten aboten@lightstep.com

This removes the need for the "Skip changelog" label and update the title to contain "[chore]".

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten requested review from a team and jpkrohling January 25, 2023 16:01
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 58.87% // Head: 58.87% // No change to project coverage 👍

Coverage data is based on head (5eb6c08) compared to base (12f662b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   58.87%   58.87%           
=======================================
  Files          44       44           
  Lines        1994     1994           
=======================================
  Hits         1174     1174           
  Misses        690      690           
  Partials      130      130           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MrAlias
Copy link
Contributor

MrAlias commented Jan 25, 2023

How is the changelog CI check skipped without the "Skip Changelog" label?

@mx-psi
Copy link
Member

mx-psi commented Jan 25, 2023

How is the changelog CI check skipped without the "Skip Changelog" label?

Having [chore] in the name is another way of skipping the check

if: ${{ !contains(github.event.pull_request.labels.*.name, 'dependencies') && !contains(github.event.pull_request.labels.*.name, 'Skip Changelog') && !contains(github.event.pull_request.title, '[chore]')}}

@codeboten codeboten merged commit b92b334 into open-telemetry:main Jan 25, 2023
@codeboten codeboten deleted the codeboten/update-title branch January 25, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants