Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semconvgen: add only flag to proccess only a specified type #217

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Jan 5, 2023

Closes #216

@frzifus frzifus requested review from a team and dmitryax January 5, 2023 15:15
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 58.19% // Head: 58.19% // No change to project coverage 👍

Coverage data is based on head (f894f78) compared to base (197f254).
Patch has no changes to coverable lines.

❗ Current head f894f78 differs from pull request most recent head 2a3c504. Consider uploading reports for the commit 2a3c504 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   58.19%   58.19%           
=======================================
  Files          44       44           
  Lines        1928     1928           
=======================================
  Hits         1122     1122           
  Misses        680      680           
  Partials      126      126           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

semconvgen/generator.go Outdated Show resolved Hide resolved
semconvgen/generator.go Outdated Show resolved Hide resolved
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@Aneurysm9 Aneurysm9 merged commit b354012 into open-telemetry:main Jan 6, 2023
@frzifus frzifus deleted the semconv_add_only_flag branch January 6, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

semconv: missing support for "only" flag.
2 participants