Process Propagator: Allow looking up parent when parent is a named process #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tsloughter
approved these changes
Jan 26, 2024
|
Can you add a quick test? |
|
And sign the CLA. |
jeffutter
force-pushed
the
process-propagator-non-pid-parent
branch
from
fa351dc to
bc5ccaf
Compare
jeffutter
force-pushed
the
process-propagator-non-pid-parent
branch
2 times, most recently
from
e7a5a38 to
e85f0f3
Compare
|
👋 I added a test for this. |
jeffutter
force-pushed
the
process-propagator-non-pid-parent
branch
from
e85f0f3 to
c3b6eb6
Compare
|
@tsloughter got that CLA signed. Please let me know if there are any other issues here. Thanks! |
|
Can you rebase or modify your settings? The PR was not opened with allow edits by maintainers. |
jeffutter
force-pushed
the
process-propagator-non-pid-parent
branch
from
c3b6eb6 to
bd99bfe
Compare
|
@bryannaegele rebased. |
bryannaegele
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like sometimes the ancestor field in the pdict contains both pids and named processes. I've noticed this in particular with Broadway.